Gitiles
Code Review Sign In
gerrit.pixelexperience.org / bootable_recovery / e95902280c362cec38bc79c63e0da5cc35241e2b
commite95902280c362cec38bc79c63e0da5cc35241e2b[log] [tgz]
authorTao Bao <tbao@google.com>Sun Apr 16 15:40:10 2017 -0700
committerTao Bao <tbao@google.com>Sun Apr 16 15:53:47 2017 -0700
treea73a7d0ba4bb94abd491c0a284bb99eb341cd135
parent1b28a27c33e3f60fce661ddf4f2f0c5abefb63bc [diff]
libmounts: Remove two dead functions.

find_mounted_volume_by_device() and remount_read_only() have no active
users. And we don't have a code logic that requires these two functions.

Test: mmma bootable/recovery
Test: Code search shows no user.
Change-Id: Ib11c2ba93ee087ea020c1337eb06686a6165f894
2 files changed
tree: a73a7d0ba4bb94abd491c0a284bb99eb341cd135
  1. .clang-format
  2. Android.mk
  3. CleanSpec.mk
  4. NOTICE
  5. README.md
  6. adb_install.cpp
  7. adb_install.h
  8. applypatch/
  9. asn1_decoder.cpp
  10. asn1_decoder.h
  11. boot_control/
  12. bootloader.h
  13. bootloader_message/
  14. common.h
  15. default_device.cpp
  16. device.cpp
  17. device.h
  18. edify/
  19. error_code.h
  20. etc/
  21. fonts/
  22. fuse_sdcard_provider.cpp
  23. fuse_sdcard_provider.h
  24. fuse_sideload.cpp
  25. fuse_sideload.h
  26. install.cpp
  27. install.h
  28. interlace-frames.py
  29. minadbd/
  30. minui/
  31. mounts.cpp
  32. mounts.h
  33. otafault/
  34. otautil/
  35. print_sha1.h
  36. recovery-persist.cpp
  37. recovery-persist.rc
  38. recovery-refresh.cpp
  39. recovery-refresh.rc
  40. recovery.cpp
  41. res-560dpi ⇨ res-xxxhdpi
  42. res-hdpi/
  43. res-mdpi/
  44. res-xhdpi/
  45. res-xxhdpi/
  46. res-xxxhdpi/
  47. roots.cpp
  48. roots.h
  49. rotate_logs.cpp
  50. rotate_logs.h
  51. screen_ui.cpp
  52. screen_ui.h
  53. stub_ui.h
  54. tests/
  55. tools/
  56. ui.cpp
  57. ui.h
  58. uncrypt/
  59. update_verifier/
  60. updater/
  61. verifier.cpp
  62. verifier.h
  63. wear_touch.cpp
  64. wear_touch.h
  65. wear_ui.cpp
  66. wear_ui.h
README.md

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.