fuse_sideload: Change the minimal block size to 4096.

run_fuse_sideload() is passing the block size as the max_read
option, so it will only handle a request that involves at most two
blocks at a time. However, the minimal allowed value was set to 1024
prior to this CL, which is inconsistent with the kernel code
(fs/fuse/inode.c) that sets it to the greater of 4096 and the passed-in
max_read option. This would fail the calls with a block size / max_read
less than 4096 due to the wrongly computed block indices.

Note that we didn't observe real issue in practice, because we have been
using 64 KiB block sizes for both of adb and sdcard sideload calls. The
issue only shows up in my local CL (to come later) that uses 1024 block
size in run_fuse_sideload() tests.

Test: recovery_component_test
Test: adb sideload with the new recovery image on angler
Change-Id: Id9f0cfea13d0d193dcb7cd41a1553a23739545f2
4 files changed
tree: 23f6adecaf4f372e2d2c593ed5e6802f3684b73e
  1. .clang-format
  2. Android.mk
  3. CleanSpec.mk
  5. README.md
  6. adb_install.cpp
  7. adb_install.h
  8. applypatch/
  9. asn1_decoder.cpp
  10. asn1_decoder.h
  11. boot_control/
  12. bootloader.h
  13. bootloader_message/
  14. common.h
  15. default_device.cpp
  16. device.cpp
  17. device.h
  18. edify/
  19. error_code.h
  20. etc/
  21. fonts/
  22. fuse_sdcard_provider.cpp
  23. fuse_sdcard_provider.h
  24. fuse_sideload.cpp
  25. fuse_sideload.h
  26. install.cpp
  27. install.h
  28. interlace-frames.py
  29. minadbd/
  30. minui/
  31. mounts.cpp
  32. mounts.h
  33. otafault/
  34. otautil/
  35. print_sha1.h
  36. private/
  37. recovery-persist.cpp
  38. recovery-persist.rc
  39. recovery-refresh.cpp
  40. recovery-refresh.rc
  41. recovery.cpp
  42. res-hdpi/
  43. res-mdpi/
  44. res-xhdpi/
  45. res-xxhdpi/
  46. res-xxxhdpi/
  47. roots.cpp
  48. roots.h
  49. rotate_logs.cpp
  50. rotate_logs.h
  51. screen_ui.cpp
  52. screen_ui.h
  53. stub_ui.h
  54. tests/
  55. tools/
  56. ui.cpp
  57. ui.h
  58. uncrypt/
  59. update_verifier/
  60. updater/
  61. verifier.cpp
  62. verifier.h
  63. wear_touch.cpp
  64. wear_touch.h
  65. wear_ui.cpp
  66. wear_ui.h

The Recovery Image

Quick turn-around testing

mm -j && m ramdisk-nodeps && m recoveryimage-nodeps

# To boot into the new recovery image
# without flashing the recovery partition:
adb reboot bootloader
fastboot boot $ANDROID_PRODUCT_OUT/recovery.img

Running the tests

# After setting up environment and lunch.
mmma -j bootable/recovery

# Running the tests on device.
adb root
adb sync data

# 32-bit device
adb shell /data/nativetest/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest/recovery_component_test/recovery_component_test

# Or 64-bit device
adb shell /data/nativetest64/recovery_unit_test/recovery_unit_test
adb shell /data/nativetest64/recovery_component_test/recovery_component_test

Running the manual tests

recovery-refresh and recovery-persist executables exist only on systems without /cache partition. And we need to follow special steps to run tests for them.

  • Execute the test on an A/B device first. The test should fail but it will log some contents to pmsg.

  • Reboot the device immediately and run the test again. The test should save the contents of pmsg buffer into /data/misc/recovery/inject.txt. Test will pass if this file has expected contents.

ResourceTest validates whether the png files are qualified as background text image under recovery.

1. `adb sync data` to make sure the test-dir has the images to test.
2. The test will automatically pickup and verify all `_text.png` files in
   the test dir.